Repository navigation
feat(libSceSaveData): declare three Prospero mount and count exports by their hash-verified names - #5121
Closed
parl0v wants to merge 1 commit into
Closed
feat(libSceSaveData): declare three Prospero mount and count exports by their hash-verified names#5121parl0v wants to merge 1 commit into
parl0v wants to merge 1 commit into
Conversation
…by their hash-verified names
Progress report (a2a3a3a → 331f1a7)📉 System libraries: 87.77% (-0.07%, +3 declared functions) 🆕 3 declared as stubs
|
CnRJay
reviewed
Oct 14, 2026
CnRJay
left a comment
CnRJay
left a comment
Contributor
There was a problem hiding this comment.
Same situation as #5123 in this series (see the review there): the names hash correctly, but no title imports these exports yet, and export-only PRs without a title that reaches the export on main have been closed (#1205, #1208, #950). Keeping the names in sce_symbols and reopening once a title's log shows one of them would match current review practice.
Collaborator
|
Closing: no title is known to reach this. With the queue at 700+ open PRs, please hold off on new PRs that don't name a title needing the change until it's down. If a title stops on this on current main, reopen with the title ID and the log line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Declares 3 exports by name: Prospero save-data mount variants and the updated-data count. Each is a throwing stub (
NotImplemented_nid_no_patch) declared without parameters, with an Unknown function info entry in its library's technical debt file.NxxouhCA12csceSaveDataGetUpdatedDataCountProsperoQaI8L6NzmJUsceSaveDataMount5ProsperofIu-ckf3n-osceSaveDataMountSysProspero2The names come from the shared NID database, where I added them (zecoxao/sce_symbols #22 and #23). Each name hashes to its NID with
tools/nid_names.py compute_nid, and the library is the module that exports the NID in the 10.01 system modules.No title I know of imports these yet, so nothing calls them today. With them declared, a title that does import one resolves it by name and stops with that name in the
NotImplementedmessage instead of an unresolved NID at load. Implementations can then replace the stubs one by one.Tested
libstarget builds;tools/check_conventions.py --base origin/mainpasses.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)